Merged
Conversation
ntrel
commented
Nov 17, 2016
std/variant.d
Outdated
| */ | ||
|
|
||
| int opCmp(T)(T rhs) | ||
| if (allowed!T) |
Contributor
Author
There was a problem hiding this comment.
BTW allowed already allows T to be VariantN.
Member
There was a problem hiding this comment.
may want to put this in a comment
ntrel
force-pushed
the
variant-constraints
branch
2 times, most recently
from
123d031 to
fff1d03
Compare
andralex
approved these changes
Nov 20, 2016
std/variant.d
Outdated
| */ | ||
|
|
||
| int opCmp(T)(T rhs) | ||
| if (allowed!T) |
Member
There was a problem hiding this comment.
may want to put this in a comment
This avoids internal error messages in VariantN.this.
ntrel
force-pushed
the
variant-constraints
branch
from
fff1d03 to
e36fb0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits.