Make std.container.rbtree.RedBlackTree._add @safe#4914
Merged
andralex merged 1 commit intodlang:masterfrom Nov 20, 2016
tom-tan:safe-rbtree-_add
Merged
Make std.container.rbtree.RedBlackTree._add @safe#4914andralex merged 1 commit intodlang:masterfrom tom-tan:safe-rbtree-_add
andralex merged 1 commit intodlang:masterfrom
tom-tan:safe-rbtree-_add
Conversation
Member
|
Auto-merge toggled on |
Member
|
Could you please push again - the FreeBSD machine is timing out. |
Contributor
Author
|
Thanks! |
Member
|
Thank you! Shows how dumb pre-optimization can be 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request removes a void initializer from
_addand makes most unittests instd.container.rbtree@safe.I also added
pureattribute for unittests.