Fix Issue 16611 - 'Unrecognized type const(void)' error for std.trait…

[Darredevil]

…s.fullyQualifiedName

https://issues.dlang.org/show_bug.cgi?id=16611

[dlang-bot]

Fix	Bugzilla	Description
✓	16611	std.traits.fullyQualifiedName fails with error 'Unrecognized type const(void)'

[MetaLang]

Please add one or more unittests testing this code path.

[PetarKirov]

@Darredevil

However I am not sure if this is the right approach. In theory shouldn't "const(void)" be caught by isBasicType ? Should I edit this one instead to check for const(void) as well ?

IMO, the correct fix, is to change isBasicType to:

enum bool isBasicType(T) = isScalarType!T || is(Unqual!T == void);

That would entail, adding a unittest to isBasicType for isBasicType!(const void), isBasicType!(shared void), etc. and then adding a tests to fullyQualifiedName for T == const(void) and friends.

[MetaLang]

It's a little weird that you can create a type like const void or shared void in the first place... but it seems that DMD doesn't complain (except when you try to declare a variable of those types, of course).

[schveiguy]

@MetaLang need it for declaring appropriate void arrays: const(void)[], shared(void)[], etc.

[MetaLang]

Ah, for some reason I thought that was a separate case.

[Darredevil]

@ZombineDev @MetaLang Implemented the modifications you suggested. Should be ready for merge once all tests pass.

[MetaLang]

Can you also add tests for the following qualifiers:

shared const       void
shared inout       void
shared inout const void
inout              void
inout  const       void
immutable	   void

[MetaLang]

Ditto.

[Darredevil]

Done.

[PetarKirov]

Thanks, @Darredevil! With that everything LGTM.

[MetaLang]

LGTM