Skip to content

Add changelog entry about ndslice removal#4967

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:ndslice-removal-changelog
Dec 20, 2016
Merged

Add changelog entry about ndslice removal#4967
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:ndslice-removal-changelog

Conversation

@wilzbach
Copy link
Contributor

Follow-up to #4946

CC @9il

The synchronization between Phobos and Mir turned out to be a lot of work
with litte gain. Users of `std.experimental.ndslice` are advised to
switch to the upstream $(LINK2 https://github.com/libmir/mir-std,
mir package).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9il I used the same link as you proposed in the deprecation warning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was changed to mir-algorithm. I don't think I understand now what we should put into mir-std, probably this would be only traits and meta and maybe compiler intrinsics.

changelog.dd Outdated
deprecated.)
The synchronization between Phobos and Mir turned out to be a lot of work
with litte gain. Users of `std.experimental.ndslice` are advised to
switch to the upstream $(LINK2 https://github.com/libmir/mir-std,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mir-algorithm

The synchronization between Phobos and Mir turned out to be a lot of work
with litte gain. Users of `std.experimental.ndslice` are advised to
switch to the upstream $(LINK2 https://github.com/libmir/mir-std,
mir package).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mir Algorithm package

@9il
Copy link
Member

9il commented Dec 19, 2016

Thank you for the PR!

@wilzbach wilzbach force-pushed the ndslice-removal-changelog branch from 1828122 to 0968df4 Compare December 19, 2016 08:15
@wilzbach
Copy link
Contributor Author

mir-algorithm

Argh - sorry for the copy/paste error :/
(fixed)

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 20, 2016

FYI: @MartinNowak and I are still testing a new auto-merge feature.
Don't use these labels for now ;-)

@9il
Copy link
Member

9il commented Dec 20, 2016

FYI: @MartinNowak and I are still testing a new auto-merge feature.
Don't use these labels for now ;-)

Thanks for doing this!

@dlang-bot dlang-bot merged commit bb3d78f into dlang:master Dec 20, 2016
@wilzbach wilzbach deleted the ndslice-removal-changelog branch December 20, 2016 21:36
@schveiguy
Copy link
Member

FYI: @MartinNowak and I are still testing a new auto-merge feature.
Don't use these labels for now ;-)

Hm..., not sure of the state of this, but I prefer the auto-merge system actually posting the message that auto merge has been toggled on, because that goes to my inbox. I also prefer the merge being done with the credentials of the person who toggled auto-merge. Is that possible with the way you do it?

@schveiguy
Copy link
Member

UI-wise, I like the idea of having the merge toggle in github. But I'm a bit concerned about accidentally merging because you clicked the wrong label. Definitely there needs to be a delay in merging (probably at least 20 seconds).

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 23, 2016

not sure of the state of this

General remark: as said we are just testing things and possible solutions, so this won't be set in stone. However your feedback is very welcome and I do encourage everyone to open issues.
You might also want to see our design notes.

Hm..., not sure of the state of this, but I prefer the auto-merge system actually posting the message that auto merge has been toggled on, because that goes to my inbox.

This would be very easy to do. I opened an issue to discuss it as there might be people how don't want this, but they could just setup a filter or block the bot directly.

I also prefer the merge being done with the credentials of the person who toggled auto-merge. Is that possible with the way you do it?

Me too, but we don't want to store your credentials with write access in the cloud, hence we use dlang-bot (dlangbot currently runs on Heroku).
Note

  • that the bot puts the name & email of the person who toggled in the git history
  • oAuth tokens expire from time to time, so we would need to place a button in the dlang-bot message.

UI-wise, I like the idea of having the merge toggle in github. But I'm a bit concerned about accidentally merging because you clicked the wrong label. Definitely there needs to be a delay in merging (probably at least 20 seconds).

You could also accidentally hit the "green" merge button - it would be immediate as well.

@schveiguy
Copy link
Member

You could also accidentally hit the "green" merge button - it would be immediate as well.

That's not next to the "allocator" label button 😉

@schveiguy
Copy link
Member

Hm... a crude idea on that -- the labels seem listed alphabetically, you could make the label "ZZZ auto-merge" so they are always at the bottom.

@schveiguy
Copy link
Member

that the bot puts the name & email of the person who toggled in the git history

That lessens the concern quite a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants