Merged
Conversation
wilzbach
force-pushed
the
enforce-successful-ddoc
branch
2 times, most recently
from
49288dd to
52de41e
Compare
wilzbach
force-pushed
the
enforce-successful-ddoc
branch
from
52de41e to
425f722
Compare
Contributor
Author
|
Rebased (and FWIW I already had to fix three new ddoc warnings) |
wilzbach
force-pushed
the
enforce-successful-ddoc
branch
from
425f722 to
b712452
Compare
wilzbach
force-pushed
the
enforce-successful-ddoc
branch
from
b712452 to
92c8de5
Compare
Contributor
Author
A day later and already a new violation managed to sneak in :/ |
| Params: | ||
| r = input range of characters, or array of characters | ||
| */ | ||
| auto ref byUTF(R)(R r) |
Contributor
There was a problem hiding this comment.
Hmm, I don't think we want to publicly expose this
| Params: | ||
| r = input range of characters, or array of characters | ||
| */ | ||
| auto ref byUTF(R)(R r) |
wilzbach
force-pushed
the
enforce-successful-ddoc
branch
3 times, most recently
from
28b4517 to
f426876
Compare
wilzbach
force-pushed
the
enforce-successful-ddoc
branch
from
f426876 to
70ebcb8
Compare
Contributor
Author
|
@CyberShadow considering the recent ddoc failure at druntime, this might be interesting for you. |
CyberShadow
approved these changes
Feb 26, 2017
Member
|
Yep, thanks :) |
Member
|
Instead of grepping for |
Member
|
I guess not because of the ndslice exclusions? |
Contributor
Author
Yup. I was too lazy to fix these as it will be removed soon anyways: #5187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ddoc already triggers a nice warning if there's a parameter mismatch - this PR fixes the last remaining error (expect for a eponymous templates in deprecated ndslice/iteration.d).
This PR also adds adds a CI check for sth. similar to
dmd -w -D -main -c -o- **/*.d, s.t. future additions we can ensure that no new violations get in ;-)Btw I was also looking at public symbols without Returns/Params and it seems to be a lot :/
edit: bugzilla issue for public symbols without return