Improve docs for Appender, RefAppender#4987
Merged
JackStouffer merged 4 commits intodlang:masterfrom Jan 10, 2017
Merged
Conversation
std/array.d
Outdated
|
|
||
| private alias T = ElementEncodingType!A; | ||
| /// | ||
| package alias T = ElementEncodingType!A; |
Contributor
There was a problem hiding this comment.
Instead of documenting this, it would make more sense to replace it in the signitures.
Contributor
Author
There was a problem hiding this comment.
Done. Also added 3 other commits.
ntrel
force-pushed
the
appender-docs
branch
3 times, most recently
from
d62c197 to
a129751
Compare
Contributor
Author
|
CircleCI fails: Looks like a CI bug. Although the test is not required, this makes my PR get a red cross in the PR list, and presumably reviewers ignore it. |
Contributor
IIRC the bug has been fixed in the script - rebasing your branch to upstream/master should fix it. |
* Expand some docs. * Document (Ref)Appender.T as it's used in public method signatures. * Document RefAppender.opDispatch. * Inline undocumented AppenderType. * Rename appender(E[]*) parameter -> arrayPtr to better distinguish from appender(E[]).
Also avoids private symbols in RefAppender constraint.
Contributor
Author
|
@wilzbach Thanks ;-) |
JackStouffer
approved these changes
Jan 10, 2017
Contributor
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T,AppenderType.opOpAssignoverloads.RefAppender.opDispatch.appender(E[]*)parameter ->arrayPtrto better distinguish fromappender(E[]).