Cast a void pointer to char* before subtracting it

[LemonBoy]

If both operands are pointers, and the operator is -, the pointers are subtracted and the result is divided by the size of the type pointed to by the operands. It is an error if the pointers point to different types. The type of the result is ptrdiff_t.

See DMD's PR

[dukc]

I would think int* and void* should cast the int* implicitly to void*, but according to that bug spec the first value is cast to type of the second, which is indeed dangerous. So yes, I think it should be forbidden as the docs say. If nothing else, to avoid silent breakage.

And I assume that this has to be pulled for that DMD fix to work. Let's do it, shall we?

[JackStouffer]

@LemonBoy Codecov is complaining; can you please manually verify that the line changed is covered?

Thanks

[LemonBoy]

Looks like the those lines weren't covered even before this patch, what should I do?

[JackStouffer]

@LemonBoy Please add a unit test

[LemonBoy]

Well, I tried

[JackStouffer]

Huh, must be a coverage bug.

[JackStouffer]

Auto-merge toggled on