Issue 17161 - [REG 2.072.2] Massive Regex Slowdown#5113
Merged
JackStouffer merged 1 commit intodlang:stablefrom Feb 12, 2017
Merged
Issue 17161 - [REG 2.072.2] Massive Regex Slowdown#5113JackStouffer merged 1 commit intodlang:stablefrom
JackStouffer merged 1 commit intodlang:stablefrom
Conversation
Contributor
|
JackStouffer
force-pushed
the
revert-regex
branch
2 times, most recently
from
42f4b70 to
9d8d99a
Compare
DmitryOlshansky
approved these changes
Feb 10, 2017
Member
DmitryOlshansky
left a comment
DmitryOlshansky
left a comment
There was a problem hiding this comment.
@JackStouffer After giving it some thought I agree that we must revert until after the new CTFE, so LGTM.
Member
|
Has some strange test failures on win32. |
Contributor
Author
|
I think I fixed the Windows errors. One of the Phobos admins needs to merge this because the doc builder is still error-ing. |
Contributor
Author
|
Auto-merge toggled on |
JackStouffer
force-pushed
the
revert-regex
branch
2 times, most recently
from
076e71b to
ee08989
Compare
JackStouffer
force-pushed
the
revert-regex
branch
from
ee08989 to
5a2491a
Compare
Member
|
Can you double-check my merge pls? #5122 |
Member
|
Should have been more careful. Now I realize that this rollbacks way too much - we've lost BitNFA that was proudly described on the D blog: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts all changes to the regex code from 2.072.2 onwards.
See the discussion here and here.
It's not fair of me to ask for regex development to be frozen until the new CTFE engine is done. However, it's unfair to our users to ask them to deal with a huge performance drop until the new CTFE engine is done.
Regex development can continue in a separate branch, and be merged into master when the CTFE is done.
CC @MartinNowak @DmitryOlshansky