Closed
Conversation
c1770c1 to
2a59f99
Compare
3c2b839 to
65adf43
Compare
65adf43 to
0071fa5
Compare
Contributor
Author
It seems like libdparse can recover from the syntax errors, so I can remove the "Blocked" status here :) With the dlang/tools#216 slightly more tests get parsed and interestingly in stdx.allocator.building_blocks.free_list there were some bits that only get tested in "DDoc" mode :S |
wilzbach
commented
Mar 1, 2017
posix.mak
Outdated
| # parse all public unittests from Phobos, for now some modules are excluded | ||
| rm -rf ./out | ||
| DFLAGS="$(DFLAGS) $(LIB) -defaultlib= -debuglib= $(LINKDL)" $(DUB) --compiler=$${PWD}/$(DMD) --single ../tools/phobos_tests_extractor.d -- --inputdir . --ignore "base64.d,building_blocks/free_list,building_blocks/quantizer,digest/hmac.d,file.d,index.d,math.d,ndslice/selection.d,stdio.d,traits.d,typecons.d,uuid.d" --outputdir ./out | ||
| DFLAGS="$(DFLAGS) $(LIB) -defaultlib= -debuglib= $(LINKDL)" $(DUB) --compiler=$${PWD}/$(DMD) --root=../tools/styles -c tests_extractor -- --inputdir . --ignore "index.d,ndslice/selection.d,traits.d,typecons.d,digest/hmac.d" --outputdir ./out |
Contributor
Author
There was a problem hiding this comment.
I am not sure how this pseudo unittest from std.digest.hmac should be handled:
https://github.com/dlang/phobos/blob/master/std/digest/hmac.d#L34
(it tries to parse from stdin)
wilzbach
commented
Mar 1, 2017
| a.min = 64; | ||
| a.setBounds(64, 128); // equivalent | ||
| assert(a.max == 128); | ||
| a.setBounds(64, 128); |
Contributor
Author
There was a problem hiding this comment.
The bounds can only be set once
0071fa5 to
a7fd4de
Compare
8005736 to
c6d25ad
Compare
Contributor
Author
|
Mostly superseded by #5582 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unittest examples are finally runnable on the releases docs :)
This fixes the remaining modules, s.t. all public examples can be run on dlang.org (except for
typecons.dandtraits.das they aren't parsable with libdparse andndslice/selection.das its deprecated anyways)This depends on dlang/tools#215 (version bump to libdparse) and dlang/tools#216 (small bug fix to the
tests_extractor)