Skip to content

Replace overload constraints with static if#5145

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:static-if-constraints
Closed

Replace overload constraints with static if#5145
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:static-if-constraints

Conversation

@wilzbach
Copy link
Contributor

From a recent NG thread by @WalterBright:

Also, as mentioned in the std.algorithm.mutation.remove case, constraints in Phobos often confuse "requirements" with "specializations".
Requirements should be user-facing constraints, while specializations are implementation details better handled with internal static if.

This PR picks a couple of low-hanging fruits in std.algorithm. If this PR got too large, let me know.

@JackStouffer
Copy link
Contributor

Yeah, this is a huge diff. If it's not too much work, could you please split it into multiple commits?

@quickfur
Copy link
Member

Yes, please split into multiple PRs. It's hard to review a diff this large.

@wilzbach
Copy link
Contributor Author

Yeah, this is a huge diff.

Oh sorry. It didn't look to me like this at the time.

If it's not too much work, could you please split it into multiple commits?

Not at all - it's automated

@wilzbach wilzbach closed this Feb 18, 2017
@wilzbach wilzbach deleted the static-if-constraints branch February 18, 2017 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants