Skip to content

Style: enforce no space after assert#5169

Merged
andralex merged 2 commits intodlang:masterfrom
wilzbach:style-assert-no-space
Feb 21, 2017
Merged

Style: enforce no space after assert#5169
andralex merged 2 commits intodlang:masterfrom
wilzbach:style-assert-no-space

Conversation

@wilzbach
Copy link
Contributor

BTW (and I realize you're sticking to existing style) I think Phobos style is to treat assert like a function, not a keyword (i.e. no space before ().
yah, no space after assert

First commit adds a simple check, the second one applies another RegExp (s/assert +\(/assert(/) over the Phobos codebase to be able to enforce the former automatically.

CC @andralex

@wilzbach
Copy link
Contributor Author

Style guide update PR to mention this is here: dlang/dlang.org#1578

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andralex
Copy link
Member

Please rebase

@andralex
Copy link
Member

Auto-merge toggled on

@wilzbach wilzbach force-pushed the style-assert-no-space branch from 8d74b92 to 5521541 Compare February 21, 2017 14:27
@andralex andralex merged commit 8a56002 into dlang:master Feb 21, 2017
@wilzbach wilzbach deleted the style-assert-no-space branch December 11, 2017 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants