Fix issue 17217 - std.net.isemail.isEmail doesn't work with non char …#5173
Merged
JackStouffer merged 1 commit intodlang:masterfrom Feb 21, 2017
Merged
Fix issue 17217 - std.net.isemail.isEmail doesn't work with non char …#5173JackStouffer merged 1 commit intodlang:masterfrom
JackStouffer merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
JackStouffer
force-pushed
the
issue17217
branch
from
a1ae281 to
bfe5708
Compare
DmitryOlshansky
requested changes
Feb 21, 2017
std/net/isemail.d
Outdated
| import std.uni : isNumber; | ||
|
|
||
| alias tstring = const(Char)[]; | ||
| alias TstringToken = Token!(Char); |
Member
There was a problem hiding this comment.
A simpler change is to rename current Token --> TokenImpl, and then add alias Token = TokenImpl!Char
JackStouffer
force-pushed
the
issue17217
branch
from
bfe5708 to
a91b610
Compare
Contributor
Author
|
@DmitryOlshansky Fixed |
DmitryOlshansky
approved these changes
Feb 21, 2017
Contributor
Author
|
Auto-merge toggled on |
Contributor
Author
|
I removed the label because the auto-merge label does not prioritize the PR in the auto-tester and so it was taking too long. |
Contributor
|
FYI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arrays
A simple fix with a large diff.