Remove unused debug writelns in std.algorithm#5180
Conversation
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
I assume that this cruft is a relict from times in which D wasn't that stable, so I leave this to someone with a longer history to sign off.
FWIW I think that a beautiful language (and D tries to be one) shouldn't require such redundancy for such a "simple" feature of reporting unittest results.
I am still hoping to see DIP83 come alive at some point...
std/algorithm/mutation.d
Outdated
| == [ 0, 2, 4, 6, 7, 8, 9, 10]); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| //writeln(remove!(SwapStrategy.stable)(a, 1, tuple(3, 5))); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; |
There was a problem hiding this comment.
This line can then be removed as well?
|
|
||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| //writeln(remove!(SwapStrategy.stable)(a, 1, 3, 5)); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; |
There was a problem hiding this comment.
This line can then be removed as well?
|
|
||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; | ||
| //writeln(remove!(SwapStrategy.stable)(a, 1, 5)); | ||
| a = [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]; |
There was a problem hiding this comment.
This line can then be removed as well?
JackStouffer
force-pushed
the
algorithm-cruft
branch
2 times, most recently
from
5b953ed to
9214a85
Compare
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This is harmless and won't break any existing PR on the same module
|
That code was mightily useful back in the days when dmd had more bugs than features :) |
JackStouffer
force-pushed
the
algorithm-cruft
branch
from
9214a85 to
2e90b8b
Compare
|
Auto-merge toggled on |
4 participants
These didn't even work because std.stdio wasn't imported. I highly doubt anyone was using them, and they're not particularly useful anyway.