Don't merge with upstream/master on CircleCi due to CodeCov issues#5198
Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
Closed
Don't merge with upstream/master on CircleCi due to CodeCov issues#5198wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
Author
|
So it turns out that CodeCov was behaving perfectly well, but Phobos testsuite has a lot of random elements in it that keep being (un)-covered :/ For more details: (sorry for the noise) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #5197.
Instead of disabling CodeCov, we simply revert the merged source code changes, but keep the updated
circleci.shandposix.makfile. This means that we just test the coverage information for the current PR, which should be fine as the auto-tester does test the PR for test correctness anyways.