Remove unnessesary call to text from std.conv.convError#5233
Merged
dlang-bot merged 1 commit intodlang:masterfrom Apr 28, 2017
Merged
Remove unnessesary call to text from std.conv.convError#5233dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
wilzbach
reviewed
Mar 4, 2017
| text("Unexpected ", convError_unexpected(source), | ||
| " when converting from type "~S.stringof~" to type "~T.stringof), | ||
| fn, ln); | ||
| if (source.empty) |
Contributor
There was a problem hiding this comment.
How about?
enforce!ConvException(!source.empty, ...)
Contributor
|
|
Contributor
Author
|
@klickverbot Changed |
Contributor
|
Style guide says binary operators ( Other than that, LGTM |
Contributor
Author
|
Ping @klickverbot @wilzbach |
1 similar comment
Contributor
Author
|
Ping @klickverbot @wilzbach |
Contributor
Author
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an extra array allocation.