Skip to content

std.math.IeeeFlags: make getters const#5246

Merged
dlang-bot merged 1 commit intodlang:masterfrom
aG0aep6G:IeeeFlags-const-getters
Mar 10, 2017
Merged

std.math.IeeeFlags: make getters const#5246
dlang-bot merged 1 commit intodlang:masterfrom
aG0aep6G:IeeeFlags-const-getters

Conversation

@aG0aep6G
Copy link
Contributor

@aG0aep6G aG0aep6G commented Mar 5, 2017

As requested.

Not sure if this qualifies for stable or if it should go into master.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilzbach
Copy link
Contributor

wilzbach commented Mar 5, 2017

Not sure if this qualifies for stable or if it should go into master.

I don't know either. It's not really a "bug fix" more an "enhancement", so I would have targetted master, but I doubt it matters in this case.

@wilzbach
Copy link
Contributor

wilzbach commented Mar 7, 2017

It looks like the stable branch has been "broken" by other changes:

executing out/std_regex_package.d
out/std_regex_package.d(43): Error: undefined identifier 'popFrontN'
out/std_regex_package.d(150): Error: undefined identifier 'Yes.keepSeparators'
out/std_regex_package.d(154): Error: undefined identifier 'Yes.keepSeparators'
make: *** [publictests] Error 1

DAutoTest complains as well :/

@JackStouffer
Copy link
Contributor

Mind the failures @aG0aep6G

@aG0aep6G
Copy link
Contributor Author

aG0aep6G commented Mar 9, 2017

Mind the failures @aG0aep6G

As far as I can tell, the failures of DAutoTest and circleci are not related to my changes.

@JackStouffer
Copy link
Contributor

@aG0aep6G Ah, it's because you're on stable.

There was a dmd bug with dlang.org that was fixed in master. Try changing the base branch to master.

@aG0aep6G aG0aep6G changed the base branch from stable to master March 9, 2017 17:08
@aG0aep6G aG0aep6G force-pushed the IeeeFlags-const-getters branch from 8c16e3d to ae7b33a Compare March 9, 2017 17:09
@aG0aep6G
Copy link
Contributor Author

aG0aep6G commented Mar 9, 2017

There was a dmd bug with dlang.org that was fixed in master. Try changing the base branch to master.

Changed to master. Aside: Does this mean we just cannot get anything into stable now?

@JackStouffer
Copy link
Contributor

Not unless either Andrei or Walter merges it who as far as I'm aware are the only people who can still merge with failing tests.

@dlang-bot dlang-bot merged commit 6e7ea1d into dlang:master Mar 10, 2017
@aG0aep6G aG0aep6G deleted the IeeeFlags-const-getters branch March 11, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants