Skip to content

Fix issue 17157 ctRegex.matchAll doesn't set last item in Captures#5250

Merged
andralex merged 1 commit intodlang:stablefrom
DmitryOlshansky:isssue-17157
Mar 9, 2017
Merged

Fix issue 17157 ctRegex.matchAll doesn't set last item in Captures#5250
andralex merged 1 commit intodlang:stablefrom
DmitryOlshansky:isssue-17157

Conversation

@DmitryOlshansky
Copy link
Member

Backtracking engine reused stale data in matches from the previous run.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
17157 ctRegex.matchAll doesn't set last item in Captures

@DmitryOlshansky DmitryOlshansky changed the base branch from master to stable March 8, 2017 16:22
Copy link
Contributor

@JackStouffer JackStouffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures look unrelated

@JackStouffer
Copy link
Contributor

Auto-merge toggled on

@JackStouffer
Copy link
Contributor

@DmitryOlshansky Try git force pushing to restart the doc builder

@DmitryOlshansky
Copy link
Member Author

@DmitryOlshansky Try git force pushing to restart the doc builder

Tried that to no avail. I think it's broken on stable so what's next? cc @MartinNowak

@JackStouffer
Copy link
Contributor

Auto-merge toggled off

@JackStouffer
Copy link
Contributor

@DmitryOlshansky this is the same problem with all PRs on stable.

@CyberShadow added a dlang.org workaround for a DMD bug in master, but stable is still broken. The only people who can merge this are @MartinNowak @andralex and Walter.

@CyberShadow
Copy link
Member

Fix for stable: dlang/dlang.org#1604

@andralex andralex merged commit 7200b36 into dlang:stable Mar 9, 2017
@CyberShadow
Copy link
Member

Failing CircleCI tests were fixed on master by 48a1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants