Added attributes to several functions in std.concurrency#5265
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 15, 2017
Merged
Added attributes to several functions in std.concurrency#5265dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
JackStouffer
force-pushed
the
concurrency-attrs
branch
from
2f12b09 to
de56aea
Compare
Contributor
|
Since it still compiles, and they are non-templated non-overridable member functions, I can't think of anything that could go wrong there. I'd say it should be merged with confidence. |
dnadlinger
reviewed
Mar 15, 2017
| * call = The routine to call when the queue is full. | ||
| */ | ||
| final void setMaxMsgs( size_t num, bool function(Tid) call ) | ||
| final void setMaxMsgs( size_t num, bool function(Tid) call ) @safe @nogc pure |
Contributor
There was a problem hiding this comment.
This is potentially a bit weird as it allows arbitrarily unsafe callbacks to be set from @safe code. Given that calling the delegate will be @system, everything should be okay, though, without making it excessively easy to introduce safety holes in the future.
dnadlinger
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.