Make allocators' resolveInternalPointer take a const pointer as source#5321
Make allocators' resolveInternalPointer take a const pointer as source#5321dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
|
||
| /// Ditto | ||
| pure nothrow Ternary resolveInternalPointer(void* p, ref void[] result) shared | ||
| pure nothrow |
There was a problem hiding this comment.
I think this entire function can be trusted, maybe in a later step
| Ternary resolveInternalPointer(const void* p, ref void[] result) shared | ||
| { | ||
| auto r = GC.addrOf(p); | ||
| auto r = GC.addrOf(cast(void*)p); |
There was a problem hiding this comment.
Style check failed:
Enforce space after cast(...)
grep -nrE '[^"]cast\([^)]*?\)[[:alnum:]]' $(find . -name '*.d') ; test $? -eq 1
./std/experimental/allocator/gc_allocator.d:76: auto r = GC.addrOf(cast(void*)p);
Please fix/revert :)
|
|
ping @wilzbach can dlang-bot not auto-merge when circleci complains? |
dlang/dlang-bot#69 (or we can set CircleCI as required). |
|
Yah that'd be useful, thanks. |
Yep, that would be the easiest solution... |
|
@wilzbach Should we do it? Seems like we're in agreement. |
Yes please! I have been trying to push for this since last summer :) |
OK, I've set CircleCI as required for Phobos for now, we can expand to other repos if this works well.
Oh, I knew there was a sentiment in favor of doing it, but I don't think I've received an explicit request to enable it in my inbox, otherwise I probably would have :) |
Well, there were always a few problems with our CI, so with "pushing" I meant more wanting to make it happen. |
|
I know that this is in |
No description provided.