Fix missing alignment for kernighan_ritchie allocator unittests#5345
Merged
dlang-bot merged 1 commit intodlang:stablefrom Apr 23, 2017
Merged
Fix missing alignment for kernighan_ritchie allocator unittests#5345dlang-bot merged 1 commit intodlang:stablefrom
dlang-bot merged 1 commit intodlang:stablefrom
Conversation
dnadlinger
approved these changes
Apr 23, 2017
Contributor
dnadlinger
left a comment
dnadlinger
left a comment
There was a problem hiding this comment.
The requirement is explicitly documented, so fixing up the tests is all left to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise LLVM sometimes chooses to align the stack buffers at a 4-bytes boundary (on x86_64) leading to an assertion in the
KRRegionconstructor.