Skip to content

Comments

remove .deps file generation#5372

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MartinNowak:rm_ut_deps
May 8, 2017
Merged

remove .deps file generation#5372
dlang-bot merged 1 commit intodlang:masterfrom
MartinNowak:rm_ut_deps

Conversation

@MartinNowak
Copy link
Member

  • for development, people can use the much faster std/algorithm.test targets
  • for batch unittest recompiling isn't of much interest as all the
    testers just start from a clean slate anyhow
  • furthermore the .deps generation is broken anyhow, see Issue 7016

- for development, people can use the much faster std/algorithm.test targets
- for batch unittest recompiling isn't of much interest as all the
  testers just start from a clean slate anyhow
- furthermore the .deps generation is broken anyhow, see Issue 7016
@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
7016 local import does not create -deps dependency

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+3 / -9 🎉

@wilzbach
Copy link
Contributor

wilzbach commented May 7, 2017

CC @RazvanN7 @andralex

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope @MartinNowak agrees with this... oh wait he wrote the PR!

@RazvanN7
Copy link
Collaborator

RazvanN7 commented May 7, 2017

@andralex maybe you should check this:
dlang/dmd#6748

@wilzbach
Copy link
Contributor

wilzbach commented May 7, 2017

Meh - random failures on FreeBSD again :S

timelimit -t 10 ./generated/freebsd/release/64/unittest_assert  2>&1 1>/dev/null | grep -qF "unittest_assert msg"
diff src-merge.lst.exp ./generated/freebsd/release/64/src-merge.lst
src/rt/util/typeinfo.d(184): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
src/rt/util/typeinfo.d(184): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
src/rt/util/typeinfo.d(184): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
src/rt/util/typeinfo.d(232): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
src/rt/util/typeinfo.d(232): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
src/rt/util/typeinfo.d(232): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
src/rt/util/typeinfo.d(286): Deprecation: identity comparison of static arrays implicitly coerces them to slices, which are compared by reference
gmake[1]: *** [generated/freebsd/release/64/unittest/libdruntime-ut.so] Killed: 9
gmake[1]: *** Waiting for unfinished jobs....
Testing invalid_memory_operation
gmake[2]: Leaving directory `/usr/home/braddr/sandbox/at-client/pull-2540284-FreeBSD_64_64/druntime/test/thread'
timelimit -t 10 ./generated/freebsd/release/64/invalid_memory_operation  2>&1 1>/dev/null | grep -qF "InvalidMemoryOperationError"
Testing unknown_gc
timelimit -t 10 ./generated/freebsd/release/64/unknown_gc  2>&1 1>/dev/null | grep -qF "'unknowngc'"
./generated/freebsd/release/64/merge_true ./generated/freebsd/release/64 
Testing static_dtor
gmake[1]: *** [generated/freebsd/debug/64/unittest/libdruntime-ut.so] Killed: 9
diff src-merge_true.lst.exp ./generated/freebsd/release/64/src-merge_true.lst
! timelimit -t 10 ./generated/freebsd/release/64/static_dtor  2>&1 1>/dev/null | grep -qF "dtor_called_more_than_once"
gmake[1]: *** Waiting for unfinished jobs....

@dlang-bot dlang-bot merged commit 7488da5 into dlang:master May 8, 2017
@MartinNowak MartinNowak deleted the rm_ut_deps branch August 30, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants