Get rid of static this for initializing encoding#5423
Conversation
std/encoding.d
Outdated
| { | ||
| static shared bool initialized; | ||
| import std.concurrency : initOnce; | ||
| initOnce!initialized({ initialize(); return true; }()); |
There was a problem hiding this comment.
initialize -> registerBuiltinSchemes or something like that?
There was a problem hiding this comment.
@klickverbot done and made it more local
andralex
force-pushed
the
no-more-durn-encodingInit
branch
from
f30c6b2 to
78b3328
Compare
CyberShadow
left a comment
CyberShadow
left a comment
There was a problem hiding this comment.
Does anyone actually use this module?
|
Why is this not being auto-merged? (@CyberShadow: Hopefully not.) |
|
@klickverbot: the poll only happens every five minutes or on a new status update. |
|
(there is an update in the pipeline to reduce this to one minute) |
Err, why does it need to poll? It should be completely event-driven. |
|
(Ah, I guess I hadn't approved it when adding the label, then…) |
I guess currently the approve events aren't properly handled as such or there is some bouncing to avoid over-using the GH API (I haven't looked at the code for a longer time) |
std.xml 😉 |
*cough* #5382 |
|
Oh cool! I didn't realize that was the only reference to std.encoding in std.xml. I'll take another look. |
BTW as we all agree that std.xml isn't phobosque - why don't we simply move it to undead? People who are suicidal and really want to use, are then automatically warned, but can still use it without any breakage... |
|
Our general policy is deprecate stuff that has immediate replacement. |
For reliability, events can be missed, then it'd hang forever. |
Then use events + polling to query any missed events. https://developer.github.com/v3/activity/events/ |
9 participants
Ugh encoding...