Revert "reimplement std.traits.ParameterStorageClassTuple()" by andralex · Pull Request #5469 · dlang/phobos

andralex · 2017-06-11T18:40:00Z

Reverts #5427. Let's see if this takes care of the errors in vibe.

andralex · 2017-06-11T18:40:08Z

CyberShadow · 2017-06-11T19:52:10Z

Hmm, Jenkins can't test reverts? @MartinNowak

dnadlinger · 2017-06-11T19:52:59Z

Huh? I thought reverts were just regular commits? @andralex: Perhaps just redo/amend the commit and force-push it to try again?

CyberShadow · 2017-06-11T20:03:20Z

They're on a branch on the dlang org's repo, instead of a fork.

PetarKirov · 2017-06-11T20:38:34Z

@CyberShadow @klickverbot I don't follow. According to Jenkins, this PR fixes the regression, although vibe.d still fails*. Here's the result of testing a different PR which clearly shows that regression is present there, but no with this PR.

*The compilation failure is in libasync 0.8.3 (a dependency of vibe.d). The compiler accuses this function of throwing, but both of the function's it calls are nothrow and also ~this() of throwing, the later probably caused by the following call chain: EventLoop.~this() (implicit) -> EventLoopImpl.~this() (implicit) -> HashMap.~this() -> freeArray -> Allocator.free. The last one doesn't seem to be marked as nothrow and I don't know how it did work at the time the code was written.

CyberShadow · 2017-06-11T20:40:30Z

Oh, I was clicking on the continuous-integration/jenkins/branch CI status, not /pr-merge, which looks very different.

CyberShadow · 2017-06-11T20:41:27Z

The compiler accuses this function of throwing

@ZombineDev Since you've looked at this already, any chance you can separate it into a self-contained test case? Would be easy to bisect it then.

PetarKirov · 2017-06-11T20:54:48Z

I am on the phone now, but I can try to find some time tomorrow.

wilzbach

Reverts #5427. Let's see if this takes care of the errors in vibe.

@andralex thanks a lot!
As @ZombineDev has explained and we can see, reverting this does fix the regression, we just seem to have uncovered another one.

So I would be in favor of pushing the revert and looking at the Jenkins output on the resubmission.

CyberShadow · 2017-06-11T21:06:33Z

I am on the phone now, but I can try to find some time tomorrow.

No problem, I see it's easy to reproduce so I'll bisect it myself.

CyberShadow · 2017-06-11T21:08:25Z

libasync regression introduced by dlang/dmd#6816

andralex · 2017-06-12T01:16:26Z

@wilzbach do you think you can help @WalterBright repro the vibed test environment so he can repro the problem locally?

CyberShadow · 2017-06-12T01:52:00Z

Running a reduction now.

CyberShadow · 2017-06-12T03:02:08Z

Running a reduction now.

Here's a reduced example that fails only with #5427:

void async(ARGS...)(ARGS)
{
	import std.functional;

	static void compute(ARGS)
	{
	}

	toDelegate(&compute);
}

alias test = async!(int, int);

WalterBright · 2017-06-12T03:25:15Z

I added it to #5474

WalterBright · 2017-06-12T03:29:09Z

@CyberShadow what is the error message you see?

CyberShadow · 2017-06-12T03:30:11Z

../dmd.bad/bin/../import/std/traits.d(1046): Error: parameter index must be in range 0..1 not 1LU
../dmd.bad/bin/../import/std/traits.d(1047): Error: template instance std.traits.ParameterStorageClassTuple!(void function(int, int) pure nothrow @nogc @safe).StorageClass!1LU error instantiating
../dmd.bad/bin/../import/std/traits.d(1052):        instantiated from here: StorageClass!0LU
../dmd.bad/bin/../import/std/typecons.d(4273):        instantiated from here: ParameterStorageClassTuple!(void function(int, int) pure nothrow @nogc @safe)
../dmd.bad/bin/../import/std/typecons.d(4170):        instantiated from here: generateParameters!("FuncInfo_doIt", void function(int, int) pure nothrow @nogc @safe)
../dmd.bad/bin/../import/std/functional.d(1224):        ... (2 instantiations, -v to show) ...
test.d(9):        instantiated from here: toDelegate!(void function(int, int) pure nothrow @nogc @safe)
test.d(12):        instantiated from here: async!(int, int)
../dmd.bad/bin/../import/std/functional.d(1224): Error: CTFE failed because of previous errors in generateFunction
core.exception.AssertError@ddmd/argtypes.d(201): Assertion failure
----------------
../dmd.bad/bin/dmd() [0x4fb21f]
../dmd.bad/bin/dmd(_ZN10toArgTypes10ToArgTypes12argtypemergeEP4TypeS2_j+0xae) [0x4fa99e]
../dmd.bad/bin/dmd(_ZN10toArgTypes10ToArgTypes5visitEP10TypeStruct+0x3b6) [0x4faffe]
../dmd.bad/bin/dmd(_ZN10TypeStruct6acceptEP7Visitor+0x1d) [0x5eb73d]
../dmd.bad/bin/dmd(_Z10toArgTypesP4Type+0x41) [0x4fa5c9]
../dmd.bad/bin/dmd(_ZN17StructDeclaration12finalizeSizeEv+0x214) [0x564bf4]
../dmd.bad/bin/dmd(_ZN20AggregateDeclaration13determineSizeE3Loc+0xd6) [0x4f8a4e]
../dmd.bad/bin/dmd(_ZN20AggregateDeclaration9semantic2EP5Scope+0x54) [0x4f842c]
../dmd.bad/bin/dmd(_ZN17AttribDeclaration9semantic2EP5Scope+0x76) [0x4fd64e]
../dmd.bad/bin/dmd(_ZN14DeclarationExp8semanticEP5Scope+0x3cc) [0x5917d4]
../dmd.bad/bin/dmd(_ZN24StatementSemanticVisitor5visitEP12ExpStatement+0x52) [0x61c9d2]
../dmd.bad/bin/dmd(_ZN12ExpStatement6acceptEP7Visitor+0x1a) [0x61108a]
../dmd.bad/bin/dmd(ddmd.statement.Statement ddmd.statementsem.semantic(ddmd.statement.Statement, ddmd.dscope.Scope*)+0x46) [0x62a78e]
../dmd.bad/bin/dmd(_ZN24StatementSemanticVisitor5visitEP17CompoundStatement+0xe8) [0x61cc80]
../dmd.bad/bin/dmd(_ZN17CompoundStatement6acceptEP7Visitor+0x1a) [0x611842]
../dmd.bad/bin/dmd(ddmd.statement.Statement ddmd.statementsem.semantic(ddmd.statement.Statement, ddmd.dscope.Scope*)+0x46) [0x62a78e]
../dmd.bad/bin/dmd(_ZN15FuncDeclaration9semantic3EP5Scope+0x12b9) [0x5b0b31]
../dmd.bad/bin/dmd(_ZN16TemplateInstance9semantic3EP5Scope+0x12d) [0x57786d]
../dmd.bad/bin/dmd(_ZN16TemplateInstance12trySemantic3EP5Scope+0x55) [0x57af75]
../dmd.bad/bin/dmd(_ZN16TemplateInstance8semanticEP5ScopeP5ArrayIP10ExpressionE+0xc9a) [0x57721a]
../dmd.bad/bin/dmd(void ddmd.dtemplate.functionResolve(ddmd.declaration.Match*, ddmd.dsymbol.Dsymbol, ddmd.globals.Loc, ddmd.dscope.Scope*, ddmd.root.array.Array!(ddmd.root.rootobject.RootObject).Array*, ddmd.mtype.Type, ddmd.root.array.Array!(ddmd.expression.Expression).Array*)+0x170) [0x56e5b0]
../dmd.bad/bin/dmd(_Z15resolveFuncCall3LocP5ScopeP7DsymbolP5ArrayIP10RootObjectEP4TypePS4_IP10ExpressionEi+0xc6) [0x5b792e]
../dmd.bad/bin/dmd(_ZN7CallExp8semanticEP5Scope+0x2953) [0x59b013]
../dmd.bad/bin/dmd(_ZN24StatementSemanticVisitor5visitEP12ExpStatement+0x52) [0x61c9d2]
../dmd.bad/bin/dmd(_ZN12ExpStatement6acceptEP7Visitor+0x1a) [0x61108a]
../dmd.bad/bin/dmd(ddmd.statement.Statement ddmd.statementsem.semantic(ddmd.statement.Statement, ddmd.dscope.Scope*)+0x46) [0x62a78e]
../dmd.bad/bin/dmd(_ZN24StatementSemanticVisitor5visitEP17CompoundStatement+0xe8) [0x61cc80]
../dmd.bad/bin/dmd(_ZN17CompoundStatement6acceptEP7Visitor+0x1a) [0x611842]
../dmd.bad/bin/dmd(ddmd.statement.Statement ddmd.statementsem.semantic(ddmd.statement.Statement, ddmd.dscope.Scope*)+0x46) [0x62a78e]
../dmd.bad/bin/dmd(_ZN15FuncDeclaration9semantic3EP5Scope+0x12b9) [0x5b0b31]
../dmd.bad/bin/dmd(_ZN16TemplateInstance9semantic3EP5Scope+0x12d) [0x57786d]
../dmd.bad/bin/dmd(_ZN6Module9semantic3EP5Scope+0x6c) [0x55a46c]
../dmd.bad/bin/dmd(int ddmd.mars.tryMain(ulong, const(char)**)+0x32ae) [0x5d8bf6]
../dmd.bad/bin/dmd(_Dmain+0x27) [0x5d9927]
../dmd.bad/bin/dmd(_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZ9__lambda1MFZv+0x1f) [0x70566b]
../dmd.bad/bin/dmd(void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate())+0x2a) [0x7055be]
../dmd.bad/bin/dmd(void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll()+0x30) [0x705624]
../dmd.bad/bin/dmd(void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate())+0x2a) [0x7055be]
../dmd.bad/bin/dmd(_d_run_main+0x1dc) [0x705538]
../dmd.bad/bin/dmd(main+0x17) [0x5da01f]
/usr/lib/libc.so.6(__libc_start_main+0xf1) [0x7fd7d0a21511]

WalterBright · 2017-06-12T03:30:54Z

Ok, I'm getting the same one. Thanks!

CyberShadow · 2017-06-12T03:31:00Z

Oh and I guess if a Phobos template can trigger an assertion error in the compiler, then that makes for a separate bug.

WalterBright · 2017-06-12T03:34:20Z

../dmd.bad/bin/dmd(_Z10toArgTypesP4Type+0x41) [0x4fa5c9]
../dmd.bad/bin/dmd(_ZN17StructDeclaration12finalizeSizeEv+0x214) [0x564bf4]

is a well known dmd bug fixed by dlang/dmd#6875

wilzbach · 2017-06-12T03:35:51Z

is a well known dmd bug fixed by dlang/dmd#6875

Uhm .. I do have another test, which proofs that it's not fixed by dlang/dmd#6875 ;-)

See; dlang/dmd#6894

Revert "reimplement std.traits.ParameterStorageClassTuple()"

dba38b5

wilzbach approved these changes Jun 11, 2017

View reviewed changes

WalterBright merged commit 60bcc3e into master Jun 12, 2017

WalterBright mentioned this pull request Jun 12, 2017

Revert "Revert "reimplement std.traits.ParameterStorageClassTuple()"" #5474

Closed

wilzbach mentioned this pull request Jun 12, 2017

Disallow empty statements made by semicolons dlang/dmd#6886

Merged

MartinNowak deleted the revert-5427-ParameterStorageClassTuple branch June 12, 2017 09:24

Uh oh!

Comments

Conversation

andralex commented Jun 11, 2017

Uh oh!

andralex commented Jun 11, 2017

Uh oh!

CyberShadow commented Jun 11, 2017

Uh oh!

dnadlinger commented Jun 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CyberShadow commented Jun 11, 2017

Uh oh!

PetarKirov commented Jun 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CyberShadow commented Jun 11, 2017

Uh oh!

CyberShadow commented Jun 11, 2017

Uh oh!

PetarKirov commented Jun 11, 2017

Uh oh!

wilzbach left a comment

Choose a reason for hiding this comment

Uh oh!

CyberShadow commented Jun 11, 2017

Uh oh!

CyberShadow commented Jun 11, 2017

Uh oh!

andralex commented Jun 12, 2017

Uh oh!

CyberShadow commented Jun 12, 2017

Uh oh!

CyberShadow commented Jun 12, 2017

Uh oh!

WalterBright commented Jun 12, 2017

Uh oh!

WalterBright commented Jun 12, 2017

Uh oh!

CyberShadow commented Jun 12, 2017

Uh oh!

WalterBright commented Jun 12, 2017

Uh oh!

CyberShadow commented Jun 12, 2017

Uh oh!

WalterBright commented Jun 12, 2017

Uh oh!

wilzbach commented Jun 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dnadlinger commented Jun 11, 2017 •

edited

Loading

PetarKirov commented Jun 11, 2017 •

edited

Loading

wilzbach commented Jun 12, 2017 •

edited

Loading