Revert "Sort imports in Phobos"

[CyberShadow]

Reverts #5478

Rationale:

• Sort imports in Phobos #5478 (comment)
• Sort imports in Phobos #5478 (comment)
• Sort imports in Phobos #5478 (review)

[CyberShadow]

I think it's fine if we enforce sorting of the module list only of top-level imports only.

[wilzbach]

I think it's fine if we enforce sorting of the module list only of top-level imports only.

Then people would get confused as well ;-)
Why do I have to sort the top-level imports, but not within my unittest?

[CyberShadow]

Then people would get confused as well ;-)
Why do I have to sort the top-level imports, but not within my unittest?

Nobody is going to be confused about not being forced to do something. Nothing is going to fail if the unittest imports are sorted.

[wilzbach]

Nobody is going to be confused about not being forced to do something. Nothing is going to fail if the unittest imports are sorted.

The entire point of the normalization is that we don't need to spend time anymore on nitpicking the order of imports and we do nitpick on sorted imports.
So if we revert this, it will be a "human CI" doing the work instead of a binary/bot ...

[CyberShadow]

1. If you are "nitpicking the order of imports", then why are you not also nitpicking on the order of local variables (and other avenues of normalization)? Why are imports special?
2. Is this about order of modules or order of selective imports too?
3. It's fallacious to decide on and enforce one crappy standard which is worse than any suggestion that would make sense to a human.

[wilzbach]

If you are "nitpicking the order of imports", then why are you not also nitpicking on the order of local variables (and other avenues of normalization)? Why are imports special?

You need to start somewhere ...

Is this about order of modules or order of selective imports too?

Yes - didn't you check the diff / my comments to it?

It's fallacious to decide on and enforce one crappy standard which is worse than any suggestion that would make sense to a human.

Because It makes sense in almost all cases and is thus easy to automate and is thus one thing less that drains a review.

[CyberShadow]

You need to start somewhere ...

No. You need to STOP somewhere. Enforcing proper formatting and normalization at the cost of readability are on opposite sides of the line.

Yes - didn't you check the diff / my comments to it?

That's not what I meant. Do you actually waste time nitpicking on the order of selective imports? That does seems like a waste of time, with the other obvious answer to not do it.

Because It makes sense in almost all cases

I don't think so.

[CyberShadow]

Superseded by #5481