Issue 17224 - Foreach documentation still refers to TypeTuples, rather than AliasSequences

[wilzbach]

Analogous to dlang/dlang.org#1701

[PetarKirov]

LGTM too.

[dlang-bot]

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Fix	Bugzilla	Description
✗	17224	Foreach documentation still refers to TypeTuples, rather than AliasSequences

[PetarKirov]

It seems like Jenkins fails, because this somehow publicly imported functions like staticMap, which is now not the case.

[PetarKirov]

@CyberShadow can you confirm if that's the case with ae?

[CyberShadow]

staticMap was originally in std.traits, until 5c9725d moved it to another module. So, breaking this would require going through a deprecation cycle.

Sidenote: ae was added to the project tester just a few days ago, I'm happy it caught a potential regression already :)

[wilzbach]

staticMap was originally in std.traits, until 5c9725d moved it to another module. So, breaking this would require going through a deprecation cycle.

Hmm I can only see staticMap and allSatisfy on this PR - is there more hidden legacy inheritance?

[wilzbach]

I will add a deprecation message as soon as we have figured out if just staticMap or more symbols are affected.

[PetarKirov]

LGTM, @CyberShadow?

[CyberShadow]

I think Sebastian was going to work on this some more? As per his comment:

I will add a deprecation message as soon as we have figured out if just staticMap or more symbols are affected.

Otherwise, if it doesn't break the project tester, it's good in my book.

[PetarKirov]

Sorry, I missed that.

[wilzbach]

I think Sebastian was going to work on this some more? As per his comment:

I will add a deprecation message as soon as we have figured out if just staticMap or more symbols are affected.

Yep I wanted to wait and see if someone comes forward with more symbols that should be publicly imported in std.traits. Nothing happened -> I think we can move forward here :)

However, it seems that dmd doesn't trigger the deprecation warnings. Any ideas / workarounds? (I already tried using an alias symbol instead of the selective public import).

Sample programs:

void main(string[] args)
{
    import std.traits;
    alias TL = staticMap!(Unqual, int, const int, immutable int);

    import std.meta : AliasSeq;
    static assert(is(TL == AliasSeq!(int, int, int)));
}

or one without std.meta:

void main(string[] args)
{
    import std.traits;
    alias TL = staticMap!(Unqual, int, const int, immutable int);

    import std.stdio;
    foreach (el; TL)
    {
        writeln(el.stringof);
    }
}

[JackStouffer]

@wilzbach How about leaving the deprecations to a different PR so this can be moved forward?

[wilzbach]

@wilzbach How about leaving the deprecations to a different PR so this can be moved forward?

Good idea. Done.