Skip to content

Comments

Fix booktable in std.traits#5487

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:fix-traits
Jun 24, 2017
Merged

Fix booktable in std.traits#5487
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:fix-traits

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 15, 2017

I just noticed that quite many traits aren't publicly documented, but listed in the booktable and on the other site, there are publicly documented ones, which aren't listed.

What's the story here? Were they maybe just accidentally set to public?
And what's the point behind SharedInoutOf? What would be wrong with SharedOf!(InoutOf!int)?

@PetarKirov
Copy link
Member

Let's see if closing & reopening the PR will force Jenkins to re-run the pipeline.

@PetarKirov PetarKirov closed this Jun 17, 2017
@PetarKirov PetarKirov reopened this Jun 17, 2017
@PetarKirov PetarKirov closed this Jun 24, 2017
@PetarKirov PetarKirov reopened this Jun 24, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some things that can help to speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dlang-bot dlang-bot merged commit 6e79d22 into dlang:master Jun 24, 2017
@wilzbach wilzbach deleted the fix-traits branch December 11, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants