Skip to content

Comments

Add missing closing parenthesis to changelog entry#5505

Merged
dlang-bot merged 1 commit intodlang:stablefrom
wilzbach:changelog-entries
Jun 22, 2017
Merged

Add missing closing parenthesis to changelog entry#5505
dlang-bot merged 1 commit intodlang:stablefrom
wilzbach:changelog-entries

Conversation

@wilzbach
Copy link
Contributor

Fix the upcoming changelog (https://dlang.org/changelog/2.075.0_pre.html)

Ddoc is a really nasty engine, everyone gets punished if there's a missing parenthesis ...

@CyberShadow should we automatically replace all parenthesis which aren't in macros by the LPAREN or RPAREN to avoid stuff like this in the future?
Or maybe simply counting the braces and making it a hard error? (Ddoc doesn't support this)

@CyberShadow
Copy link
Member

@CyberShadow should we automatically replace all parenthesis which aren't in macros by the LPAREN or RPAREN to avoid stuff like this in the future?

I don't think a program can know whether a parenthesis is meant literally or to close a macro.

Or maybe simply counting the braces and making it a hard error?

Yes, we should do that somehow. Doesn't DDoc print a warning for mismatched parentheses currently?

@wilzbach
Copy link
Contributor Author

Rebased to restart Jenkins (unrelated failure ...)

@dlang-bot dlang-bot merged commit 65dac04 into dlang:stable Jun 22, 2017
@wilzbach wilzbach deleted the changelog-entries branch June 22, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants