Add missing closing parenthesis to changelog entry#5505
Merged
dlang-bot merged 1 commit intodlang:stablefrom Jun 22, 2017
Merged
Add missing closing parenthesis to changelog entry#5505dlang-bot merged 1 commit intodlang:stablefrom
dlang-bot merged 1 commit intodlang:stablefrom
Conversation
Member
I don't think a program can know whether a parenthesis is meant literally or to close a macro.
Yes, we should do that somehow. Doesn't DDoc print a warning for mismatched parentheses currently? |
CyberShadow
approved these changes
Jun 22, 2017
68446eb to
0f01083
Compare
Contributor
Author
|
Rebased to restart Jenkins (unrelated failure ...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the upcoming changelog (https://dlang.org/changelog/2.075.0_pre.html)
Ddoc is a really nasty engine, everyone gets punished if there's a missing parenthesis ...
@CyberShadow should we automatically replace all parenthesis which aren't in macros by the
LPARENorRPARENto avoid stuff like this in the future?Or maybe simply counting the braces and making it a hard error? (Ddoc doesn't support this)