Skip to content

Comments

remove use of deprecated hex string literals#5507

Closed
ghost wants to merge 4 commits intomasterfrom
unknown repository
Closed

remove use of deprecated hex string literals#5507
ghost wants to merge 4 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 22, 2017

This PR removes all uses of hex string literals. It is required if dlang/dmd#6925 is accepted.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 22, 2017

Thanks for your pull request, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is blocked on @WalterBright's approval to deprecate hex strings

@ghost
Copy link
Author

ghost commented Jul 6, 2017

So i let the initiative to someone who'll be stasified by the way things are working here

@ghost ghost closed this Jul 6, 2017
@ghost ghost deleted the rem-hexstrlit branch July 6, 2017 11:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants