Fix REF links in std.file.slurp#5509
Conversation
|
Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some things that can help to speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
force-pushed
the
fix-ddoc-std-file
branch
from
688d5c4 to
fe390f1
Compare
std/file.d
Outdated
| * passed to $(REF formattedRead, std,format), and therefore must conform to the | ||
| * format string specification outlined in $(MREF format). | ||
| * passed to $(REF formattedRead, std,_format), and therefore must conform to the | ||
| * format string specification outlined in $(MREF _format). |
There was a problem hiding this comment.
Something is not right because now $(MREF _format) points to _format.html. See: http://dtest.dlang.io/artifact/website-6d28a546dff7ca825b137033aeb6aae40b31bfd1-b44f14d07a242b08d63ddb77aae7a686/web/phobos-prerelease/std_file.html#slurp
Also I think it would read better if it rendered as std.format. format. (with a dot part of the link) just looks weird, though I'm not sure why the dot gets sucked in the macro.
There was a problem hiding this comment.
It points to format_.html (underscore is on the other side). Should be: $(MREF std,_format).
wilzbach
force-pushed
the
fix-ddoc-std-file
branch
from
fe390f1 to
d2c5c53
Compare
|
Btw I just found this by accident, but really should fix the root of the problem ...
Excellent catch, @aG0aep6G! |
4 participants
We really should get rid off this anti-feature in Ddoc to auto-magically highlight all words in the doc that match the parameter or name of the symbol ... it's highly error-prone!
https://dlang.org/phobos/std_file.html#.slurp