Dscanner Makefile: separate target + order-only dependencies

[wilzbach]

No description provided.

[dlang-bot]

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[CyberShadow]

Make $(LIB) and $(LIB) an order-only dependency for DScanner

$(DMD) and $(LIB) ?

[wilzbach]

$(DMD) and $(LIB) ?

Fixed. Sorry.

[CyberShadow]

To avoid problems due to stale versions of DScanner, I'd suggest cloning it to a directory with the commit hash as part of the directory name, in the same way the dlang.org makefiles clone the stable versions of Phobos etc.

LGTM otherwise.

[wilzbach]

To avoid problems due to stale versions of DScanner, I'd suggest cloning it to a directory with the commit hash as part of the directory name, in the same way the dlang.org makefiles clone the stable versions of Phobos etc.

Excellent idea. Do you prefer long, short git hashes or simply don't care?

[CyberShadow]

I don't think it really matters, so whatever's simplest!