Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
e956f43 to
31d6357
Compare
31d6357 to
5a3ef78
Compare
|
Aww - seems like we need a new release of DUB first -> dlang/dub#1183 |
jmdavis
left a comment
There was a problem hiding this comment.
Okay. No offense, but you're doing this wrong, though I can understand why. Anything that is currently documented with a ddoc comment is not to be removed from the code. The part in the comment about it being removed is when to remove it from the documentation, not the code. So, the next step is for the ddoc comments to be removed and to be replaced with lines like
// Explicitly undocumented. It will be removed in June 2018. @@@DEPRECATED_2018-06@@@
It's only after the symbol has been deprecated and undocumented for a year that it should be removed. So, the stuff that is deprecated and has no ddoc comment can be removed, but the stuff with a ddoc comment needs to be undocumented, not removed.
If it would be easier, I can do this (I'd meant to before now but have been quite busy), but regardless, we need to not be removing any symbols that are currently documented.
I am not sure whether I can follow. Isn't all of
Sure, feel free to take over anytime. I was just seeing the |
|
I am closing this as (1) we would need to wait for a new DUB release anyways (luckily all PRs have been merged) and (2) @jmdavis is a lot better at this ;-) |

We can finally get rid of a lot of old stuff :)
As I don't have a Windows box, I am abusing auto-tester to check the Makefiles config for Windows.
Of course, it would be great if these two ugly
win{32,64}.makwouldn't be there, but that's a different discussion.