Skip to content

Comments

Move deprecations for 2017-06 ahead#5532

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:push-deprecations
Closed

Move deprecations for 2017-06 ahead#5532
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:push-deprecations

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jul 2, 2017

We can finally get rid of a lot of old stuff :)

As I don't have a Windows box, I am abusing auto-tester to check the Makefiles config for Windows.
Of course, it would be great if these two ugly win{32,64}.mak wouldn't be there, but that's a different discussion.

@wilzbach wilzbach added the Review:Trivial typos, formatting, comments label Jul 2, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach force-pushed the push-deprecations branch from e956f43 to 31d6357 Compare July 2, 2017 21:12
@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 2, 2017

image

Aww - seems like we need a new release of DUB first -> dlang/dub#1183

@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 2, 2017

As I don't have a Windows box, I am abusing auto-tester to check the Makefiles config for Windows.

The good news - auto-tester is green 🎉

But this is a giant mess. Deprecations are useless if everyone ignores them!!
At least these PRs are needed to move on:

Copy link
Member

@jmdavis jmdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. No offense, but you're doing this wrong, though I can understand why. Anything that is currently documented with a ddoc comment is not to be removed from the code. The part in the comment about it being removed is when to remove it from the documentation, not the code. So, the next step is for the ddoc comments to be removed and to be replaced with lines like

// Explicitly undocumented. It will be removed in June 2018. @@@DEPRECATED_2018-06@@@

It's only after the symbol has been deprecated and undocumented for a year that it should be removed. So, the stuff that is deprecated and has no ddoc comment can be removed, but the stuff with a ddoc comment needs to be undocumented, not removed.

If it would be easier, I can do this (I'd meant to before now but have been quite busy), but regardless, we need to not be removing any symbols that are currently documented.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 6, 2017

It's only after the symbol has been deprecated and undocumented for a year that it should be removed. So, the stuff that is deprecated and has no ddoc comment can be removed, but the stuff with a ddoc comment needs to be undocumented, not removed.

I am not sure whether I can follow. Isn't all of std.c not documented since a long time?
(The only other deprecations in this PR are in std.conv and the undocumented std.windows.iunknown)

If it would be easier, I can do this (I'd meant to before now but have been quite busy), but regardless, we need to not be removing any symbols that are currently documented.

Sure, feel free to take over anytime. I was just seeing the // @@@DEPRECATED_2017-06@@@ in std.conv and wanted to help out.

@wilzbach
Copy link
Contributor Author

I am closing this as (1) we would need to wait for a new DUB release anyways (luckily all PRs have been merged) and (2) @jmdavis is a lot better at this ;-)

@wilzbach wilzbach closed this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants