Merge remote-tracking branch 'upstream/stable' into merge_stable#5547
Merged
dlang-bot merged 16 commits intodlang:masterfrom Jul 8, 2017
Merged
Merge remote-tracking branch 'upstream/stable' into merge_stable#5547dlang-bot merged 16 commits intodlang:masterfrom
dlang-bot merged 16 commits intodlang:masterfrom
Conversation
…valid and should cause an exception
Since the previous commit, it was only called from one place.
…h JSONOptions.escapeNonAsciiChars
This switches to lazy initialization of theAllocator, so that accessing it form within `shared static this` works as expected.
Issue 17564: Eliminate "static this" for theAllocator merged-on-behalf-of: Martin Nowak <code@dawg.eu>
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla references
|
Contributor
Not sure how this managed to get through in the first place, but I amended a commit to fix it. |
wilzbach
approved these changes
Jul 5, 2017
Contributor
wilzbach
left a comment
There was a problem hiding this comment.
PRs @ Phobos need to be approved ;-)
Contributor
|
Not sure, why the bot only commented now. Please verify @MartinNowak |
Member
Author
Maybe you're not testing on stable, or maybe because everyone ignores CircleCI, since it fails quite often and takes ages to load logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.