Skip to content

Comments

Merge remote-tracking branch 'upstream/stable' into merge_stable#5547

Merged
dlang-bot merged 16 commits intodlang:masterfrom
MartinNowak:merge_stable
Jul 8, 2017
Merged

Merge remote-tracking branch 'upstream/stable' into merge_stable#5547
dlang-bot merged 16 commits intodlang:masterfrom
MartinNowak:merge_stable

Conversation

@MartinNowak
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 5, 2017

Thanks for your pull request, @MartinNowak!

Bugzilla references

Auto-close Bugzilla Description
5904 std.json parseString doesn't handle chars outside the BMP
17553 std.json should not do UTF decoding when encoding JSON
17555 [REG2.070.0] Control characters in JSON data are invalid and should cause an exception
17556 std.json encodes non-BMP characters incorrectly with JSONOptions.escapeNonAsciiChars
17557 std.json should not do UTF decoding when parsing
17564 std.experimental.allocator.theAllocator is null within shared static this

@wilzbach
Copy link
Contributor

wilzbach commented Jul 5, 2017

Enforce space between a .. b
grep -nrE '[[:alnum:]][.][.][[:alnum:]]|[[:alnum:]] [.][.][[:alnum:]]|[[:alnum:]][.][.] [[:alnum:]]' $(find etc std -name '*.d' | grep -vE 'std/string.d|std/uni.d') ; test $? -eq 1
std/json.d:1179:                        foreach (wc; wchars[0..wNum])
make: *** [style_lint] Error 1

Not sure how this managed to get through in the first place, but I amended a commit to fix it.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs @ Phobos need to be approved ;-)

@wilzbach
Copy link
Contributor

wilzbach commented Jul 5, 2017

Not sure, why the bot only commented now. Please verify @MartinNowak

@MartinNowak
Copy link
Member Author

Not sure how this managed to get through in the first place, but I amended a commit to fix it.

Maybe you're not testing on stable, or maybe because everyone ignores CircleCI, since it fails quite often and takes ages to load logs.

@dlang-bot dlang-bot merged commit 0b6b743 into dlang:master Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants