Bugfix for "undefined identifier _min" in SharedFreeList.

[chadjoan]

When instantiating SharedFreeList with a 0 minSize and a
chooseAtRuntime maxSize, it will give an error like so:

std/experimental/allocator/building_blocks/free_list.d(822): Error: undefined identifier _min, did you mean alias min?

This commit resolves the error message by using 'min' instead
of '_min', because '_min' is only available when
(minSize == chooseAtRuntime).

[dlang-bot]

Thanks for your pull request, @chadjoan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[RazvanN7]

Cool. You should add a unittest which covers the lines of code you wrote so that we get rid of the codecoverage failing test

[chadjoan]

Roger. Hope that does it.

[RazvanN7]

You should try to rebase [1] . Hopefully that will get rid of the CyberShadow failure (you probably have an older version of phobos and the tools that come with it.)

[1] https://wiki.dlang.org/Starting_as_a_Contributor#Rebasing

[wilzbach]

You should try to rebase

Thanks to the CircleCi magic at #5559, simply restarting CircleCi should be enough (I just did this)

[wilzbach]

Looks reasonable, though while you are at it, a test for min as well, wouldn't hurt ;-)

[CyberShadow]

Hopefully that will get rid of the CyberShadow failure (you probably have an older version of phobos and the tools that come with it.)

I don't think that should cause the documentation tester to fail.

Please ping me if everything but the documentation tester is failing, and you think it shouldn't.

[chadjoan]

I squashed/rebased and added a test for min being chooseAtRuntime while maxSize is chosen at compile time.

[wilzbach]

I squashed/rebased and added a test for min being chooseAtRuntime while maxSize is chosen at compile time.

Thanks. I also added deallocateAll on exit as, even if the sizes are small, it's a good practice to cleanup the "global state" one messed with after each tests.