Skip to content

Comments

Fix Issue 17369 - [Module std.traits] Documentation lists ditto in table#5558

Merged
dlang-bot merged 2 commits intodlang:masterfrom
RazvanN7:Issue_17369
Jul 6, 2017
Merged

Fix Issue 17369 - [Module std.traits] Documentation lists ditto in table#5558
dlang-bot merged 2 commits intodlang:masterfrom
RazvanN7:Issue_17369

Conversation

@RazvanN7
Copy link
Collaborator

@RazvanN7 RazvanN7 commented Jul 6, 2017

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Fix Bugzilla Description
17369 [Module std.traits] Documentation lists ditto in table

{
/// Add specific qualifier to the given type T.
/// Add the mutable qualifier to the given type T.
template MutableOf(T) { alias MutableOf = T ; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is package and shouldn't be displayed on the docs ...

DScanner issue: dlang-community/D-Scanner#493

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wilzbach
Copy link
Contributor

wilzbach commented Jul 6, 2017

I fixed your typo in the commit message it's MutableOf, not ConstOf ;-)

Regarding the CircleCi failure, see #5559

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why MutableOf was set to package, so leaving this to more experienced reviewers to finally approve ;-)

@RazvanN7
Copy link
Collaborator Author

RazvanN7 commented Jul 6, 2017

Thanks for the fix!

@JackStouffer
Copy link
Contributor

@wilzbach looks like there's an error with dscanner.

@wilzbach
Copy link
Contributor

wilzbach commented Jul 6, 2017

@wilzbach looks like there's an error with dscanner.

It's libdparse, but yep, aware of it -> #5559
(without #5559 the fix is to rebase, to latest, greatest upstream/master)

@dlang-bot dlang-bot merged commit 0d7ce7f into dlang:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants