Skip to content

improve docs for std.math.FloatingPointControl#5574

Merged
dlang-bot merged 3 commits intodlang:masterfrom
aG0aep6G:FloatingPointControl-StdDdoc
Jul 8, 2017
Merged

improve docs for std.math.FloatingPointControl#5574
dlang-bot merged 3 commits intodlang:masterfrom
aG0aep6G:FloatingPointControl-StdDdoc

Conversation

@aG0aep6G
Copy link
Contributor

@aG0aep6G aG0aep6G commented Jul 7, 2017

Mostly showing docs that were accidentally invisible before. See commit messages for details.

aG0aep6G added 3 commits July 7, 2017 23:15
The doc comments were there but not actually attached to anything. Using
version(StdDdoc) and lots of "ditto" to make them visible.
Because `rounding`'s signatures refer to it.
Now rounding functionality comes first, and then exception functionality.
Before, it was a back-and-forth between them.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wilzbach wilzbach added Severity:Documentation Review:Trivial typos, formatting, comments labels Jul 7, 2017
Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@dlang-bot dlang-bot merged commit ecef6f0 into dlang:master Jul 8, 2017
@aG0aep6G aG0aep6G deleted the FloatingPointControl-StdDdoc branch July 8, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants