Skip to content

Re-enable unittest-debug Makefile to increase Phobos overall coverage#5580

Closed
wilzbach wants to merge 3 commits intodlang:masterfrom
wilzbach:circle-coverage
Closed

Re-enable unittest-debug Makefile to increase Phobos overall coverage#5580
wilzbach wants to merge 3 commits intodlang:masterfrom
wilzbach:circle-coverage

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jul 8, 2017

Follow-up to #5579

I will have a look if coverSetMerge can help here to get the best from both worlds.

It's already enabled, so running the unittest-debug as an extra step might increase the build time a bit, but should increase the overall coverage a bit.
(this is an experiment)

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 8, 2017

Seems like it isn't that easy:

image

Never mind then, sorry.

@wilzbach wilzbach closed this Jul 8, 2017
@wilzbach wilzbach deleted the circle-coverage branch July 8, 2017 21:17
@wilzbach wilzbach reopened this Jul 10, 2017
@wilzbach
Copy link
Contributor Author

Seems like it isn't that easy:

I forgot that we need to set coverage to merging, so I am testing whether a hack to call the respective Druntime function would improve things.

@wilzbach
Copy link
Contributor Author

Still doesn't seem to work, I guess a good intermediate solution would be adding a -covmerge flag to DMD which simplifies this runtime fiddling for the users and Phobos.

@wilzbach wilzbach closed this Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants