Convert range primitives to CNF like a boss#5613
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
andralex
left a comment
There was a problem hiding this comment.
Love this, I need to approve my own PR :)
|
This PR caused a regression: The reason this fails is because the new One might argue that the above code is bad because |
| enum bool isInputRange(R) = | ||
| is(typeof(R.init) == R) | ||
| && is(ReturnType!((R r) => r.empty) == bool) | ||
| && is(typeof((R r) => r.front)) |
There was a problem hiding this comment.
This line fails if the range being tested has a front method annotated with return.
|
Filed an issue for this regression: https://issues.dlang.org/show_bug.cgi?id=17661 |
#5461, but this time hopefully without CI weirdness