std.range.package - add asserts/static asserts for unused variables in unittests#5635
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 24, 2017
Merged
Conversation
RazvanN7
requested review from
JackStouffer,
PetarKirov,
andralex and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Contributor
Yes, that's why tooling wins. |
Collaborator
Author
|
@wilzbach many of those are used in traits compiles statements and static asserts. Looks like dscanner misses the case were variables are used at compile time tests. |
Contributor
|
I welcome the added |
Collaborator
Author
|
@JackStouffer they get rid of useless assignments. |
andralex
reviewed
Jul 20, 2017
Member
andralex
left a comment
andralex
left a comment
There was a problem hiding this comment.
static assert ain't bad but a better test also make sure the result of the compiled code is as expected.
std/range/package.d
Outdated
| int[4] testArr = [1,2,3,4]; | ||
| //just checking it compiles | ||
| auto s = testArr[].stride(2); | ||
| static assert(__traits(compiles,testArr[].stride(2))); |
Member
There was a problem hiding this comment.
better yet also assert it equals [1, 3].
Collaborator
Author
There was a problem hiding this comment.
doing so may cause a GC allocation which makes the unittest drop the @nogc. Since the test is not public, maybe it would be better to leave it like this
Contributor
There was a problem hiding this comment.
@nogc unittest
{
static immutable result = [1, 3];
auto s = testArr[].stride(2);
assert(s.equal(result));
}
Member
There was a problem hiding this comment.
yah there's a solution to everything - just ask around and mess with things!
std/range/package.d
Outdated
| // Make sure bug 3311 is fixed. ChainImpl should compile even if not all | ||
| // elements are mutable. | ||
| auto c = chain( iota(0, 10), iota(0, 10) ); | ||
| static assert(__traits(compiles, chain( iota(0, 10), iota(0, 10)))); |
Member
There was a problem hiding this comment.
same here, assert not only it compiles but it yields a range as expected.
std/range/package.d
Outdated
| immutable(Foo)[] a; | ||
| immutable(Foo)[] b; | ||
| auto c = chain(a, b); | ||
| static assert(__traits(compiles, chain(a, b))); |
Contributor
Yeah quite likely - there's no semantic phase at DScanner. |
RazvanN7
force-pushed
the
Unused_Variables_range_package
branch
2 times, most recently
from
20bbe87 to
07bb328
Compare
RazvanN7
force-pushed
the
Unused_Variables_range_package
branch
from
07bb328 to
1e44763
Compare
Collaborator
Author
|
@andralex I think this is good to go now |
andralex
approved these changes
Jul 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most likely I missed some.