Skip to content

Comments

Remove all mentions of TypeTuple from std.meta#5638

Merged
dlang-bot merged 1 commit intomasterfrom
MetaLang-patch-1
Jul 20, 2017
Merged

Remove all mentions of TypeTuple from std.meta#5638
dlang-bot merged 1 commit intomasterfrom
MetaLang-patch-1

Conversation

@MetaLang
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MetaLang! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@MetaLang MetaLang requested a review from wilzbach July 20, 2017 19:48
@MetaLang MetaLang added the Review:Trivial typos, formatting, comments label Jul 20, 2017
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for thinking about this! :)

std/meta.d Outdated

/**
* Returns a typetuple created from TList with the all occurrences,
* Returns a `AliasSeq` created from TList with the all occurrences,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have "an" as well (ditto for the other).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, fixed.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Probably you want to squash your second commit?

@MetaLang
Copy link
Member Author

I'm using the web UI so I can't at the moment. I'll do it in a bit.

@wilzbach
Copy link
Contributor

I'm using the web UI so I can't at the moment. I'll do it in a bit.

Ah I was just asking whether you agree -> squashed :)

@wilzbach wilzbach added Review:Trivial typos, formatting, comments and removed Review:Trivial typos, formatting, comments labels Jul 20, 2017
@dlang-bot dlang-bot merged commit d68a6c3 into master Jul 20, 2017
@MetaLang MetaLang deleted the MetaLang-patch-1 branch July 21, 2017 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants