Skip to content

Comments

Add documentation and unittests regarding multisets - take #3#5645

Merged
wilzbach merged 1 commit intodlang:masterfrom
RazvanN7:Setops_doc
Jul 21, 2017
Merged

Add documentation and unittests regarding multisets - take #3#5645
wilzbach merged 1 commit intodlang:masterfrom
RazvanN7:Setops_doc

Conversation

@RazvanN7
Copy link
Collaborator

@RazvanN7 RazvanN7 commented Jul 21, 2017

Applied review from #5643.

CC @andralex

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@RazvanN7 RazvanN7 changed the title Add documentation and unittests regarding multisets Add documentation and unittests regarding multisets - take #3 Jul 21, 2017
Copy link
Member

@MetaLang MetaLang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilzbach wilzbach merged commit 35429a3 into dlang:master Jul 21, 2017
@andralex
Copy link
Member

thx!

@wilzbach
Copy link
Contributor

Yeah, all good things are three!

@andralex
Copy link
Member

I swear I didn't search the Net for what follows: "Alle gute Dinge sind drei"...?

@andralex
Copy link
Member

ok off by a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants