Skip to content

Comments

std.conv: Make constraint for toImpl with radix clearer#5647

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ntrel:toImpl-radix
Jul 24, 2017
Merged

std.conv: Make constraint for toImpl with radix clearer#5647
dlang-bot merged 1 commit intodlang:masterfrom
ntrel:toImpl-radix

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Jul 22, 2017

parse with radix requires isIntegral!T anyway.

`parse` with radix requires isIntegral!T.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@dlang-bot dlang-bot merged commit b17c657 into dlang:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants