Fix issue 17667 - regex([r".", r"[\(\{[\]\}\)]"]);

[DmitryOlshansky]

Missing check in charset parser + side effect of how multi-pattern regex was implemented.

[dlang-bot]

Thanks for your pull request, @DmitryOlshansky!

Bugzilla references

Auto-close	Bugzilla	Description
✓	17667	regex([r".", r"[({[]})]"]);

[andralex]

Why does all that code appear uncovered?

[DmitryOlshansky]

Why does all that code appear uncovered?

Well at least one of the ifs I think is uncovered the others dunno.
Will add a couple of tests to cover all.

[DmitryOlshansky]

Done. Also fixed a number of unreported issues with multi-pattern regex.

[andralex]

@MartinNowak OK to override the failing codecov?

[DmitryOlshansky]

Regex unittests historically leave in a separate file, that may have fooled the codecov.

[MartinNowak]

Regex unittests historically leave in a separate file, that may have fooled the codecov.

Yes, see #5579 (comment).
We'd need to change the single test make target to also compile the separate tests with -unittest.