Fix issue 17668 - assert failure regex(q"<[^]>")#5657
Merged
dlang-bot merged 1 commit intodlang:stablefrom Aug 7, 2017
Merged
Conversation
Contributor
|
Thanks for your pull request, @DmitryOlshansky! Bugzilla references
|
DmitryOlshansky
force-pushed
the
issue-17668
branch
from
af64e42 to
ed5eeb6
Compare
atilaneves
reviewed
Jul 25, 2017
| thrown = true; | ||
| } | ||
| assert(thrown); | ||
| } |
Contributor
There was a problem hiding this comment.
assert(collectExceptionMsg(regex(q"<[^]>").canFind("no operand for '^'"));
Member
Author
There was a problem hiding this comment.
Done, for some reason it seemed to not work the first time I tried i.e. exception escaped.
DmitryOlshansky
force-pushed
the
issue-17668
branch
3 times, most recently
from
57a015f to
aeba147
Compare
Contributor
|
LGTM |
atilaneves
approved these changes
Jul 30, 2017
DmitryOlshansky
force-pushed
the
issue-17668
branch
from
aeba147 to
a9bb641
Compare
DmitryOlshansky
requested review from
CyberShadow,
JackStouffer,
MartinNowak,
MetaLang,
PetarKirov,
andralex,
burner,
dnadlinger,
ibuclaw,
jmdavis,
kyllingstad,
schveiguy and
wilzbach
as code owners
DmitryOlshansky
force-pushed
the
issue-17668
branch
from
a9bb641 to
a82c5dc
Compare
DmitryOlshansky
removed request for
CyberShadow,
JackStouffer,
MartinNowak,
MetaLang,
PetarKirov,
andralex,
dnadlinger,
ibuclaw,
jmdavis,
kyllingstad,
schveiguy and
wilzbach
DmitryOlshansky
force-pushed
the
issue-17668
branch
from
a82c5dc to
ba15802
Compare
Member
Author
|
Damn it's trivially easy to rebase on the wrong branch... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another mistake in charset parser code.
It's rather baroque I wish we could use some parser combinators for it, should easily fit operator grammar.