[std.regex] Fix issue 17458 - add messages to asserts

[DmitryOlshansky]

No description provided.

[dlang-bot]

Thanks for your pull request, @DmitryOlshansky!

Bugzilla references

Auto-close	Bugzilla	Description
✓	17458	[std.regex] Assertion failure in package.d

[UplinkCoder]

LGTM

[CyberShadow]

Thanks!

BTW, nitpicking but generally exception messages are capitalized (like a sentence, but without trailing punctuation).

[DmitryOlshansky]

BTW, nitpicking but generally exception messages are capitalized (like a sentence, but without trailing punctuation).

I just followed what I had in this module. I'm not opposed to wholesale change of asserts in std.regex

[CyberShadow]

I just followed what I had in this module.

I found just one existing instance (

phobos/std/regex/package.d

Line 600 in f8ca347

assert(_f + i < _b,text("requested submatch number ", i," is out of range"));

).

I'm not opposed to wholesale change of asserts in std.regex

Feel free to, or to not :) It might be better to wait for #5578 , then it should be easier to find and fix the remaining message-less asserts, and update the messages on the other ones along the way.