Skip to content

fix issue 17192 - ParameterDefaults fails when parameter is called "i"#5671

Merged
dlang-bot merged 1 commit intodlang:stablefrom
aG0aep6G:ParameterDefaults
Aug 7, 2017
Merged

fix issue 17192 - ParameterDefaults fails when parameter is called "i"#5671
dlang-bot merged 1 commit intodlang:stablefrom
aG0aep6G:ParameterDefaults

Conversation

@aG0aep6G
Copy link
Contributor

@aG0aep6G aG0aep6G commented Aug 2, 2017

Improved reboot of the abandoned #5446.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 2, 2017

Thanks for your pull request, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17192 ParameterDefaults fails when parameter is called "i"

@aG0aep6G aG0aep6G force-pushed the ParameterDefaults branch from a2c2ad4 to 2e063e9 Compare August 2, 2017 20:33
@aG0aep6G aG0aep6G changed the base branch from master to stable August 2, 2017 20:33
@aG0aep6G aG0aep6G changed the title fix issue 17192 fix issue 17192 - ParameterDefaults fails when parameter is called "i" Aug 2, 2017
@dlang-bot dlang-bot merged commit 5d3c842 into dlang:stable Aug 7, 2017
@JackStouffer
Copy link
Contributor

Ping @wilzbach. This PR was merged without complaints from circle, despite the unit test missing an annotation.

@wilzbach
Copy link
Contributor

wilzbach commented Aug 8, 2017

Ping @wilzbach. This PR was merged without complaints from circle, despite the unit test missing an annotation.

Looks like it used an old circleci.sh file:

Running DScanner
../dscanner/dsc --config .dscanner.ini --styleCheck $(find etc std -type f -name '*.d' | grep -vE 'std/traits.d|std/typecons.d') -I.

It should auto-merge with stable before running the test pipeline, but I can't tell from my phone why this didn't work.

@MartinNowak
Copy link
Member

Ping @wilzbach. This PR was merged without complaints from circle, despite the unit test missing an annotation.

I guess you mean attributes @JackStouffer, @safe more specifically.

@aG0aep6G aG0aep6G deleted the ParameterDefaults branch August 21, 2017 17:28
tramker pushed a commit to tramker/phobos that referenced this pull request Feb 8, 2018
fix issue 17192 - ParameterDefaults fails when parameter is called "i"
merged-on-behalf-of: Martin Nowak <code@dawg.eu>

cherry-picked-by: Martin Krejcirik <mk@krej.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants