Skip to content

fix issue 17780 - Malformed DDOC links in std.range#5707

Closed
ghost wants to merge 16 commits intostablefrom
unknown repository
Closed

fix issue 17780 - Malformed DDOC links in std.range#5707
ghost wants to merge 16 commits intostablefrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 27, 2017

No description provided.

schveiguy and others added 16 commits August 16, 2017 11:35
send/receive. Also now allows all types of shared items to be stored in
a Variant.
In operator from righthand side for SortedRange.
merged-on-behalf-of: MetaLang <MetaLang@users.noreply.github.com>
fix issue 13262 - Cannot send certain shared data to another thread
Fix Issue 9183 - Add a Nullable.get(x) overload
merged-on-behalf-of: Jack Stouffer <jack@jackstouffer.com>
This only does the move without adapting
the interface to the commonly accepted ranges.
Fix Issue 6004 - std.range.unzip()
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
Add public API for regex charset parser
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
Merge remote-tracking branch 'upstream/stable' into merge_stable
merged-on-behalf-of: Jack Stouffer <jack@jackstouffer.com>
@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 27, 2017

Thanks for your pull request, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
6004 std.range.unzip()
9183 Add a Nullable.get(x) overload
13262 Cannot send certain shared data to another thread
17780 Malformed DDOC links in std.range

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target stable so that it appears faster on dlang.org
I'm currently without a desktop and rebasing is a bit difficult on my smartphone. Would you be so kind to retarget this PR?

@ghost
Copy link
Author

ghost commented Aug 27, 2017

why not put in master and cherry pick in stable ?

@wilzbach
Copy link
Contributor

why not put in master and cherry pick in stable ?

Would be another PR which I can't do today

@PetarKirov
Copy link
Member

As a general workflow we don't cherry pick, only merge stable into master.

@PetarKirov PetarKirov changed the base branch from master to stable August 27, 2017 07:27
@ghost
Copy link
Author

ghost commented Aug 27, 2017

I didn't see the other commits yesterday. THe proper PR is #5708

@ghost ghost closed this Aug 27, 2017
@ghost ghost deleted the issue-17780 branch August 27, 2017 07:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants