Fix issue 17801: DateTime.fromISOExtString no longer works with const strings.#5721
Merged
dlang-bot merged 1 commit intodlang:stablefrom Sep 5, 2017
Merged
Fix issue 17801: DateTime.fromISOExtString no longer works with const strings.#5721dlang-bot merged 1 commit intodlang:stablefrom
dlang-bot merged 1 commit intodlang:stablefrom
Conversation
Contributor
… strings. The from*String functions in std.datetime did not have tests to make sure that they worked with various character types or various levels of constness, and some optimizations that were done to the from*String functions on DateTime for 2.076 broke them for const strings. So, this adds tests for all character types and levels of constness to each of the from*String function in std.datetime, and fixes the functionality for DateTime that then doesn't pass the tests.
JackStouffer
approved these changes
Sep 3, 2017
PetarKirov
approved these changes
Sep 3, 2017
Member
|
Closing & reopening to restart DAutoTest. |
MetaLang
approved these changes
Sep 4, 2017
Contributor
|
Big thanks with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fromString functions in std.datetime did not have tests to make
sure that they worked with various character types or various levels of
constness, and some optimizations that were done to the fromString
functions on DateTime for 2.076 broke them for const strings. So, this
adds tests for all character types and levels of constness to each of
the from*String function in std.datetime, and fixes the functionality
for DateTime that then doesn't pass the tests.