Skip to content

Small clean-ups of architecture-specific code in FloatingPointControl#5769

Merged
dlang-bot merged 8 commits intodlang:masterfrom
ibuclaw:fpcontrol
Oct 28, 2017
Merged

Small clean-ups of architecture-specific code in FloatingPointControl#5769
dlang-bot merged 8 commits intodlang:masterfrom
ibuclaw:fpcontrol

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Oct 8, 2017

Slight continuation of #4272.

Changes:

  • FloatingPointControl.roundingMask: New public RoundingMode value
  • FloatingPointControl.ExceptionMask: New public base type for exception mask enum.
  • EXCEPTION_MASK, ROUNDING_MODE: Remove internal values.

Now, the only parts that need changing for adding ports are FPU exception masks, and the asm code which gets/set the control word.

@ibuclaw ibuclaw requested a review from dnadlinger as a code owner October 8, 2017 23:02
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw ibuclaw added the math label Oct 8, 2017
@ibuclaw
Copy link
Member Author

ibuclaw commented Oct 28, 2017

Ping?

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty then

roundUp, /// ditto
roundToZero /// ditto
roundToZero, /// ditto
roundingMask, /// ditto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch with that comma

@dlang-bot dlang-bot merged commit c69914c into dlang:master Oct 28, 2017
@ibuclaw ibuclaw deleted the fpcontrol branch October 29, 2017 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants