Skip to content

Comments

Solaris: add import clock_gettime to currStdTime#5807

Merged
dlang-bot merged 1 commit intodlang:masterfrom
nykytenko:solaris-currStdTime
Oct 30, 2017
Merged

Solaris: add import clock_gettime to currStdTime#5807
dlang-bot merged 1 commit intodlang:masterfrom
nykytenko:solaris-currStdTime

Conversation

@nykytenko
Copy link
Contributor

fix skipped "import clock_gettime"

@nykytenko nykytenko requested a review from jmdavis as a code owner October 24, 2017 19:21
@DmitryOlshansky
Copy link
Member

@nykytenko wow, does D work on Solaris?

@nykytenko
Copy link
Contributor Author

Yes, but with LDC only.

@DmitryOlshansky
Copy link
Member

std/typecons.d(2018:36)[warn]: Left side of logical or is identical to right side.

WAT?

I'm really impressed by poor quality of our mandatory lint check.
https://github.com/dlang/phobos/blob/master/std/typecons.d#L2018

@jmdavis
Copy link
Member

jmdavis commented Oct 27, 2017

I'm really impressed by poor quality of our mandatory lint check.
https://github.com/dlang/phobos/blob/master/std/typecons.d#L2018

Yeah, not only does that have nothing to do with this PR, it's not even true.

@wilzbach Any idea what's going on here? Was dscanner updated to be more stupid?

@PetarKirov
Copy link
Member

The problem with this error is that I can't reproduce it locally (make -f posix.mak style_lint), even with the exact same git commit hash on several pull-requests. I'll try to investigate more later today.

@jmdavis
Copy link
Member

jmdavis commented Oct 29, 2017

@nykytenko Can you just do a quick git commit --amend (you don't have to change anything, just run the command and save the message as-is so that the commit has a new ID), and then do git push -f to push the changes to your branch again so that all of the checks will be run again, and hopefully this time, the bizarre circleci failure won't happen, and the changes can be merged.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @nykytenko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dlang-bot dlang-bot merged commit 58dc045 into dlang:master Oct 30, 2017
chunorig pushed a commit to chunorig/gcc-kludges that referenced this pull request Jan 26, 2019
Commits merged from druntime.

    Fix struct tls_index definition on x32
    dlang/druntime#2354

    Update SectionGroup signatures to match on all targets
    dlang/druntime#2401

    Fix issue 19128 - argument to alloca may be too large
    dlang/druntime#2409

    Define some common filesystem limits in core.stdc.limits
    dlang/druntime#2460

    Use version Darwin instead of OSX in core.sys.posix.aio
    dlang/druntime#2470

Commits merged from phobos.

    Don't run HardFloat tests on SoftFloat systems
    dlang/phobos#5358

    Remove reliance on stdin, stdout, stderr being aliasable
    dlang/phobos#5718

    Solaris: add import clock_gettime to currStdTime
    dlang/phobos#5807

    Don't print debug messages when building unittests
    dlang/phobos#6827

    Add HPPA support to phobos
    Fixes https://gcc.gnu.org/PR89054
    dlang/phobos#6836

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268293 138bc75d-0d04-0410-961f-82ee72b054a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants