Skip to content

Comments

Revert "Merge pull request #5470#5815

Closed
PetarKirov wants to merge 1 commit intodlang:masterfrom
PetarKirov:revert-5470
Closed

Revert "Merge pull request #5470#5815
PetarKirov wants to merge 1 commit intodlang:masterfrom
PetarKirov:revert-5470

Conversation

@PetarKirov
Copy link
Member

This reverts commit 87bdeae, reversing changes made to b5e6365, since it breaks the Dustmite, among probably other projects.

…parallelism"

This reverts commit 87bdeae, reversing
changes made to b5e6365.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ZombineDev!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@andralex
Copy link
Member

So what happened here? I see two unrelated pull requests mentioned.

@PetarKirov
Copy link
Member Author

PetarKirov commented Oct 27, 2017

@andralex The first part of my pull request description was generated automatically by git. It means that your pull-request (#5470) will be reverted and after that the master branch will be in the same state as before (#5470) was merged - the last commit effective commit will be b5e6365 (which remains intact).

(Never mind my previous PR - #5814 - only this one is needed. The difference is that in my previous attempt I used GitHub's revert feature, which for some reason didn't play nice with our Jenkins CI. Now that I used git revert -m 1 87bdeaee41f7bedbc3a5f974eedc013377ef3822 from my local machine and pushed the changes to a branch in my fork as one is supposed to do, it looks like everything is ok.)

@andralex
Copy link
Member

I suggest #5816 instead. I plan to expose the functionality publicly but would like to work the kinks out for a release cycle.

@PetarKirov
Copy link
Member Author

Yes, I would prefer #5816 too.

@PetarKirov PetarKirov closed this Oct 27, 2017
@PetarKirov PetarKirov deleted the revert-5470 branch October 27, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants